From 18dc994de731c8c5d58e7c9ad72379018944f38d Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 17 Jan 2018 19:12:27 -0500 Subject: [PATCH] inspector: Don't leak recordings g_list_model_get_item is transfer full, so we need to drop the references we get from it. This was showing up while testing the GL texture cache in GtkGLArea. --- gtk/inspector/recorder.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gtk/inspector/recorder.c b/gtk/inspector/recorder.c index 921b21d778..32dcfb0db7 100644 --- a/gtk/inspector/recorder.c +++ b/gtk/inspector/recorder.c @@ -120,6 +120,9 @@ recordings_list_row_selected (GtkListBox *box, } gtk_tree_view_expand_all (GTK_TREE_VIEW (priv->render_node_tree)); + + if (recording) + g_object_unref (recording); } static void @@ -773,6 +776,8 @@ gtk_inspector_recorder_recordings_list_create_widget (gpointer item, { GtkInspectorRecording *r = g_list_model_get_item (priv->recordings, i); + g_object_unref (r); + if (r == recording) break; -- 2.30.2